-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact(decisionService): Move ProjectConfig from DecisionService constructor to individual methods #175
Conversation
1 similar comment
* | ||
* @return Variation Variation which the user is bucketed into. | ||
*/ | ||
public function getVariation(Experiment $experiment, $userId, $attributes = null) | ||
public function getVariation($projectConfig, Experiment $experiment, $userId, $attributes = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please strict type it ProjectConfig to ensure that it's an instance of ProjectConfig. Also do it for all other methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Test plan